Make AnsibleTower checkout/execute actions more resilient #341
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
broker/providers/ansible_tower.py:622
- The new retry logic introduced by resilient_job_wait should be covered by tests to ensure it works correctly.
resilient_job_wait(job)
pyproject.toml:131
- [nitpick] Removing the TRY302 rule might allow exception handlers that re-raise errors immediately, which could lead to less clear error handling. Consider keeping this rule or ensuring that exception handlers are reviewed carefully.
"TRY302", # Remove exception handler; error is immediately re-raised
ogajduse
approved these changes
Jan 14, 2025
We've been seeing some issues with service interruptions in AAP under high load. While the jobs do complete successfully, awxkit bails when encountering the connection issue. With this change, we simple enter a retry loop when monitoring job status.
JacobCallahan
force-pushed
the
yolo_checkout
branch
from
c0a1920 to
4d1453f
Compare
That seems pretty indicative that this works for intent. |
bherrin3
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing some issues with service interruptions in AAP under high load. While the jobs do complete successfully, awxkit bails when encountering the connection issue.
With this change, we simple enter a retry loop when monitoring job status.